Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in Contributors.md - Fixes #38651 #38649

Conversation

chincholikarsalil
Copy link

@chincholikarsalil chincholikarsalil commented Apr 26, 2021

Fixed extra spaces and bullets - Fixes #38651

@chincholikarsalil chincholikarsalil changed the title Fix typo in Contributions.md Fix typo in Contributors.md Apr 26, 2021
@chincholikarsalil chincholikarsalil changed the title Fix typo in Contributors.md Fixed typo in Contributors.md Apr 26, 2021
@chincholikarsalil chincholikarsalil changed the title Fixed typo in Contributors.md Fixed typo in Contributors.md - Issue #38651 Apr 26, 2021
@chincholikarsalil chincholikarsalil changed the title Fixed typo in Contributors.md - Issue #38651 Fixed typo in Contributors.md - Fixes #38651 Apr 26, 2021
@chincholikarsalil
Copy link
Author

@adreaskar @afrozchakure
Sorry for poking in, but can you please check?

Copy link

@glaukiol1 glaukiol1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the project @chincholikarsalil!

@chincholikarsalil
Copy link
Author

Hey, thanks! I have updated the file again to resolve the conflicts. I hope this helps.
@glaukiol1

Copy link

@glaukiol1 glaukiol1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Approved

@Roshanjossey
Copy link
Member

Hi, I appreciate you cleaning up the format but this results in multiple merge conflicts and prevents me from merging. Could you please submit another pull request by adding your name only?

If you didn't make changes to other lines deliberately, it's possible that your IDE made the changes with a utility like prettier. Next time, make sure that you only add your changes by using git add -p and rather than git add Contributors.md

Feel free to ask me any questions if you need further clarifications :)

Cheers

@chincholikarsalil
Copy link
Author

@Roshanjossey Hey, I tried cleaning it up multiple times, but there were no reviewers to review the requests, so I left the attempt after a few tries.
I have already added my name in a previous commit, but I saw that many people have not followed a standard format to write their names. I thought it will be better if I try to do it for everyone, which resulted into this commit. But again, it was not possible as reviewers were not active.
Anyways, cheers!

@chincholikarsalil chincholikarsalil deleted the fix-contributions-typo branch August 3, 2021 03:19
@Roshanjossey
Copy link
Member

@chincholikarsalil, please read through point 3 in #35892. If you have a difference of opinion, we can have a discussion in that thread.

@chincholikarsalil
Copy link
Author

@Roshanjossey, Okay, great.
That makes sense. I should have read it before, my bad.
Thank you!

@Roshanjossey
Copy link
Member

Cool cool cool. Happy hacking 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos (Extra spaces and/or Issues with bullets) in Contributors.md
4 participants