-
-
Notifications
You must be signed in to change notification settings - Fork 81.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in Contributors.md - Fixes #38651 #38649
Fixed typo in Contributors.md - Fixes #38651 #38649
Conversation
@adreaskar @afrozchakure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to the project @chincholikarsalil!
Hey, thanks! I have updated the file again to resolve the conflicts. I hope this helps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Approved
Hi, I appreciate you cleaning up the format but this results in multiple merge conflicts and prevents me from merging. Could you please submit another pull request by adding your name only? If you didn't make changes to other lines deliberately, it's possible that your IDE made the changes with a utility like prettier. Next time, make sure that you only add your changes by using Feel free to ask me any questions if you need further clarifications :) Cheers |
@Roshanjossey Hey, I tried cleaning it up multiple times, but there were no reviewers to review the requests, so I left the attempt after a few tries. |
@chincholikarsalil, please read through point 3 in #35892. If you have a difference of opinion, we can have a discussion in that thread. |
@Roshanjossey, Okay, great. |
Cool cool cool. Happy hacking 😊 |
Fixed extra spaces and bullets - Fixes #38651