Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: character select screen tweak #915

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nickrehac
Copy link

make character/hat selection more obvious by keeping eyes mostly in the center of the character panel

Screenshot from 2024-02-03 17-02-54
Screenshot from 2024-02-03 17-02-47
Screenshot from 2024-02-03 17-02-42

@nickrehac nickrehac changed the title character select screen tweak feat: character select screen tweak Feb 3, 2024
Copy link
Member

@zicklag zicklag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thanks for the PR!

One thing I would like to do is make sure that the player stays the same size before and after selecting the skin. For example, in the screenshot below, the player on the left that hasn't been locked in, is smaller than the skin after you confirm the player selection.

image

We should try to keep the player the same size before and after confirming.

Another minor tweak is to use the pixel font and size for the hat selection name:

image

I would also like just a little bit more space between the hat's label, and the hat itself. Just a little. 🤏

@nickrehac
Copy link
Author

Thanks for the feedback!
I looked into the character scaling and found the sprite sheet has a considerable amount of padding which throws off the ui and might be better suited as part of the ui construction itself. I'm going to check if that padding is needed elsewhere

@nickrehac
Copy link
Author

fixed the size and added spacing.
characters drop down when selected which could be an indicator of selection status, but is actually egui being quirky
thoughts?

Screenshot from 2024-02-06 13-57-11

@zicklag
Copy link
Member

zicklag commented Feb 13, 2024

Hi @nickrehac, sorry for the delay. Life has had me incredibly busy recently. Could you push the code with the updated size and spacing?

As far as the egui issue, there must be some way to fix it, but me or someone else can try to take a look at it if we get the chance. I do want to get that fixed before merging.

@nickrehac
Copy link
Author

Here you go, and no worries.
I might take a crack at this last bit soon. It seems that calculating the sprite size each frame is unavoidable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants