-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: character select screen tweak #915
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, thanks for the PR!
One thing I would like to do is make sure that the player stays the same size before and after selecting the skin. For example, in the screenshot below, the player on the left that hasn't been locked in, is smaller than the skin after you confirm the player selection.
We should try to keep the player the same size before and after confirming.
Another minor tweak is to use the pixel font and size for the hat selection name:
I would also like just a little bit more space between the hat's label, and the hat itself. Just a little. 🤏
Thanks for the feedback! |
Hi @nickrehac, sorry for the delay. Life has had me incredibly busy recently. Could you push the code with the updated size and spacing? As far as the egui issue, there must be some way to fix it, but me or someone else can try to take a look at it if we get the chance. I do want to get that fixed before merging. |
Here you go, and no worries. |
make character/hat selection more obvious by keeping eyes mostly in the center of the character panel