-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React native to ts-client #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add auth --------- Co-authored-by: Szymon Kania <[email protected]>
* Handle partial response from enumerateDeivce * Apply changes to enumarateDevice function
* Add lint and local package * Fix dist * Apply suggestions from code review Co-authored-by: Kamil Stasiak <[email protected]>
* Auth format update * Update client * Remove peerid and roomid --------- Co-authored-by: Przemysław Rożnawski <[email protected]>
* Configure format * format * Format vanilla * Remove token log
* Add gh-pages docs * Format
* Update readme * Add minimal example * Update readme with example * Add minimal react example * format * Rtc-206 gh pages documentation (#14) * Add gh-pages docs * Format * Fix react strict * Change type to interface * Add docs to logging * Add more docs * Format * Remove unused files * Add more examples * Format
Co-authored-by: Szymon Kania <[email protected]>
* Update references to websocket url to match skd changes * Update `ts-client-sdk` version in lock files
Add hls.js player
Co-authored-by: Szymon Kania <[email protected]> Co-authored-by: Konrad Bochnia <[email protected]>
Add useUserMedia hook
* Remove dashboard * Remove 'check dashboard action'
* Add track field * Fix format
## Description This PR introduces changes from: fishjam-dev/ts-client-sdk#49 and also: ### useCamera, useMicrophone, useScreenshare Hooks for managing a single track of a given type in the global state (similarly to the React Native API). #### onDeviceStop `onDeviceStop?: "remove" | "mute"; This PR introduces a new `onDeviceStop` config parameter that allows the user to decide what to do if a track stops. Without it, the track has been removed from `RTCPeerConnection`. Now, with the option `mute`, that track can be reused later without renegotiation. It is a companion event to `onDeviceChange`. Added `onDeviceStop`, `onDeviceChange`, and the ability to stop a device to `use-camera-and-microphone-example`. #### onDeviceChange `onDeviceChange?: "replace" | "stop";` Determines whether a track should be replaced when the user requests a device change. Previously, `broadcastOnDeviceChange`. #### Other changes - Names of types like `UseMicrophoneResult` changed to something simpler, like `MicrophoneAPI`. ## Motivation and Context Fishjam now offers the ability to reuse tracks. ## Types of changes - [ ] Bug fix (a non-breaking change that fixes an issue) - [ ] New feature (a non-breaking change that adds functionality) - [x] Breaking change (a fix or feature that would cause existing functionality to not work as expected) - The `replaceTrack` method can handle a nullable track parameter. - The `stream` parameter was removed from the `addTrack` method.
…-with-react-client
…react-client-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Types of changes
not work as expected)