FCE 756 enable unit test and remove validators

.github/workflows/node.yaml

@@ -31,6 +31,9 @@ jobs:
       - name: Build 📦
         run: yarn build
 
+      - name: Test 🧑‍🔬
+        run: yarn test:unit
+
       - name: Check formatting 🎨
         run: yarn format:check
 

e2e-tests/react-client/docker-compose-test.yaml

@@ -2,7 +2,7 @@ version: "3"
 
 services:
   fishjam:
-    image: "ghcr.io/fishjam-cloud/fishjam:0.8.0"
+    image: "ghcr.io/fishjam-cloud/fishjam:0.9.0"
     container_name: fishjam
     restart: on-failure
     healthcheck:

e2e-tests/ts-client/app/src/App.tsx

@@ -24,67 +24,31 @@ export type TrackMetadata = {
   goodTrack: string;
 };
 
-function endpointMetadataParser(a: unknown): EndpointMetadata {
-  if (
-    typeof a !== "object" ||
-    a === null ||
-    !("goodStuff" in a) ||
-    typeof a.goodStuff !== "string"
-  )
-    throw "Invalid metadata!!!";
-  return { goodStuff: a.goodStuff };
-}
-
-function trackMetadataParser(a: unknown): TrackMetadata {
-  if (
-    typeof a !== "object" ||
-    a === null ||
-    !("goodTrack" in a) ||
-    typeof a.goodTrack !== "string"
-  )
-    throw "Invalid track metadata!!!";
-  return { goodTrack: a.goodTrack };
-}
-
 class RemoteStore {
   cache: Record<
     string,
-    [
-      Record<string, Endpoint<EndpointMetadata, TrackMetadata>>,
-      Record<string, TrackContext<EndpointMetadata, TrackMetadata>>,
-    ]
+    [Record<string, Endpoint>, Record<string, TrackContext>]
   > = {};
   invalidateCache: boolean = false;
 
-  constructor(
-    private webrtc: WebRTCEndpoint<EndpointMetadata, TrackMetadata>,
-  ) {}
+  constructor(private webrtc: WebRTCEndpoint) {}
 
   subscribe(callback: () => void) {
     const cb = () => {
       this.invalidateCache = true;
       callback();
     };
 
-    const trackCb: TrackContextEvents<
-      EndpointMetadata,
-      TrackMetadata
-    >["encodingChanged"] = () => cb();
+    const trackCb: TrackContextEvents["encodingChanged"] = () => cb();
 
-    const trackAddedCb: WebRTCEndpointEvents<
-      EndpointMetadata,
-      TrackMetadata
-    >["trackAdded"] = (context) => {
+    const trackAddedCb: WebRTCEndpointEvents["trackAdded"] = (context) => {
       context.on("encodingChanged", () => trackCb);
       context.on("voiceActivityChanged", () => trackCb);
 
       callback();
     };
 
-    const removeCb: WebRTCEndpointEvents<
-      EndpointMetadata,
-      TrackMetadata
-    >["trackRemoved"] = (context) => {
+    const removeCb: WebRTCEndpointEvents["trackRemoved"] = (context) => {
       context.removeListener("encodingChanged", () => trackCb);
       context.removeListener("voiceActivityChanged", () => trackCb);
 
@@ -127,10 +91,7 @@ class RemoteStore {
 // Assign a random client ID to make it easier to distinguish their messages
 const clientId = Math.floor(Math.random() * 100);
 
-const webrtc = new WebRTCEndpoint({
-  endpointMetadataParser,
-  trackMetadataParser,
-});
+const webrtc = new WebRTCEndpoint();
 (window as typeof window & { webrtc: WebRTCEndpoint }).webrtc = webrtc;
 const remoteTracksStore = new RemoteStore(webrtc);
 
@@ -289,14 +250,7 @@ export function App() {
         <MockComponent webrtc={webrtc} />
         <div style={{ width: "100%" }}>
           {Object.values(remoteTracks).map(
-            ({
-              stream,
-              trackId,
-              endpoint,
-              metadata,
-              rawMetadata,
-              metadataParsingError,
-            }) => (
+            ({ stream, trackId, endpoint, metadata }) => (
               <div
                 key={trackId}
                 data-endpoint-id={endpoint.id}
@@ -305,16 +259,6 @@ export function App() {
                 <div>Endpoint id: {endpoint.id}</div>
                 Metadata:{" "}
                 <code className="metadata">{JSON.stringify(metadata)}</code>
-                <br />
-                Raw:{" "}
-                <code className="raw-metadata">
-                  {JSON.stringify(rawMetadata)}
-                </code>
-                <br />
-                Error:{" "}
-                <code className="metadata-parsing-error">
-                  {metadataParsingError}
-                </code>
                 <div style={{ display: "flex", flexDirection: "column" }}>
                   <VideoPlayerWithDetector
                     id={endpoint.id}
@@ -342,27 +286,14 @@ export function App() {
         <hr />
         <div id="endpoints-container">
           Endpoints:
-          {Object.values(remoteEndpoints).map(
-            ({ id, metadata, rawMetadata, metadataParsingError }) => (
-              <details key={id} open>
-                <summary>{id}</summary>
-                metadata:{" "}
-                <code id={`metadata-${id}`}>
-                  {JSON.stringify(metadata.peer)}
-                </code>
-                <br />
-                raw metadata:{" "}
-                <code id={`raw-metadata-${id}`}>
-                  {JSON.stringify(rawMetadata.peer)}
-                </code>
-                <br />
-                metadata parsing error:{" "}
-                <code id={`metadata-parsing-error-${id}`}>
-                  {metadataParsingError?.toString?.() ?? metadataParsingError}
-                </code>
-              </details>
-            ),
-          )}
+          {Object.values(remoteEndpoints).map(({ id, metadata }) => (
+            <details key={id} open>
+              <summary>{id}</summary>
+              metadata:{" "}
+              <code id={`metadata-${id}`}>{JSON.stringify(metadata)}</code>
+              <br />
+            </details>
+          ))}
         </div>
       </div>
     </div>

e2e-tests/ts-client/app/src/MockComponent.tsx

@@ -1,7 +1,6 @@
 import { createStream } from "./mocks";
 import { VideoPlayer } from "./VideoPlayer";
 import { useRef, useState } from "react";
-import type { EndpointMetadata, TrackMetadata } from "./App";
 import type {
   BandwidthLimit,
   SimulcastConfig,
@@ -22,7 +21,7 @@ export const heartMock = createStream("🫀", "white", "low", 24);
 export const heart2Mock = createStream("💝", "#FF0000", "low", 24);
 
 type Props = {
-  webrtc: WebRTCEndpoint<EndpointMetadata, TrackMetadata>;
+  webrtc: WebRTCEndpoint;
 };
 
 export const MockComponent = ({ webrtc }: Props) => {

e2e-tests/ts-client/app/src/MuteTrackTest.tsx

@@ -3,7 +3,6 @@ import { brain2Mock, heart2Mock } from "./MockComponent";
 import { useEffect, useState } from "react";
 import { VideoPlayer } from "./VideoPlayer";
 import type { WebRTCEndpointEvents } from "@fishjam-cloud/ts-client/webrtc";
-import type { EndpointMetadata, TrackMetadata } from "./App";
 
 type Props = {
   webrtc: WebRTCEndpoint;
@@ -15,19 +14,17 @@ export const MuteTrackTest = ({ webrtc }: Props) => {
   const [trackId, setTrackId] = useState<string | null>(null);
 
   useEffect(() => {
-    const localTrackAdded: WebRTCEndpointEvents<
-      EndpointMetadata,
-      TrackMetadata
-    >["localTrackAdded"] = (event) => {
+    const localTrackAdded: WebRTCEndpointEvents["localTrackAdded"] = (
+      event,
+    ) => {
       setCurrentStream(event.stream);
       setCurrentTrack(event.track);
       setTrackId(event.trackId);
     };
 
-    const localTrackReplaced: WebRTCEndpointEvents<
-      EndpointMetadata,
-      TrackMetadata
-    >["localTrackReplaced"] = (event) => {
+    const localTrackReplaced: WebRTCEndpointEvents["localTrackReplaced"] = (
+      event,
+    ) => {
       setCurrentTrack(event.track);
     };
 

e2e-tests/ts-client/docker-compose-test.yaml

@@ -2,7 +2,7 @@ version: '3'
 
 services:
   fishjam:
-    image: "ghcr.io/fishjam-cloud/fishjam:0.8.0"
+    image: "ghcr.io/fishjam-cloud/fishjam:0.9.0"
     container_name: fishjam
     restart: on-failure
     healthcheck: