Review changes

app/src/main/AndroidManifest.xml

@@ -11,6 +11,7 @@
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE_MICROPHONE" />
     <uses-permission android:name="android.permission.CAMERA" />
+    <uses-permission android:name="android.permission.RECORD_AUDIO" />
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
 
     <application
@@ -28,7 +29,7 @@
             android:name=".CameraService"
             android:enabled="true"
             android:exported="false"
-            android:foregroundServiceType="camera|microphone|mediaProjection">
+            android:foregroundServiceType="camera|microphone">
         </service>
 
         <activity
@@ -40,7 +41,7 @@
             android:name=".MainActivity"
             android:exported="true"
             android:label="@string/app_name"
-            android:theme="@style/Theme.FishjamAndroidExample" >
+            android:theme="@style/Theme.FishjamAndroidExample">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
 

app/src/main/java/com/example/fishjamandroidexample/CameraService.kt

@@ -1,6 +1,5 @@
 package com.example.fishjamandroidexample
 
-import android.app.ForegroundServiceStartNotAllowedException
 import android.app.NotificationChannel
 import android.app.NotificationManager
 import android.app.Service
@@ -12,36 +11,28 @@ import android.os.IBinder
 import androidx.core.app.NotificationCompat
 import androidx.core.app.ServiceCompat
 import androidx.core.content.ContextCompat
+import timber.log.Timber
 
 class CameraService : Service() {
     private fun startForeground() {
-        // Before starting the service as foreground check that the app has the
-        // appropriate runtime permissions. In this case, verify that the user has
-        // granted the CAMERA permission.
         val cameraPermission =
             ContextCompat.checkSelfPermission(this, android.Manifest.permission.CAMERA)
         if (cameraPermission == PackageManager.PERMISSION_DENIED) {
-            // Without camera permissions the service cannot run in the foreground
-            // Consider informing user or updating your app UI if visible.
             stopSelf()
             return
         }
 
         try {
             val channelID = "FISHJAM_NOTIFICATION_CHANNEL"
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
-                // Create the NotificationChannel.
                 val name = "Fishjam notification channel"
                 val importance = NotificationManager.IMPORTANCE_DEFAULT
                 val mChannel = NotificationChannel(channelID, name, importance)
-                // Register the channel with the system. You can't change the importance
-                // or other notification behaviors after this.
                 val notificationManager = getSystemService(NOTIFICATION_SERVICE) as NotificationManager
                 notificationManager.createNotificationChannel(mChannel)
             }
             val notification =
                 NotificationCompat.Builder(this, channelID)
-                    // Create the notification to display while the service is running
                     .setContentTitle("Fishjam is running")
                     .build()
             ServiceCompat.startForeground(
@@ -55,13 +46,7 @@ class CameraService : Service() {
                 }
             )
         } catch (e: Exception) {
-            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S &&
-                e is ForegroundServiceStartNotAllowedException
-            ) {
-                // App not in a valid state to start foreground service
-                // (e.g. started from bg)
-            }
-            // ...
+            Timber.w("Failed to start foreground service")
         }
     }