Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

[EX-483] Code cleanups required after library merge #16

Merged
merged 8 commits into from
May 20, 2024
Merged

Conversation

mironiasty
Copy link
Contributor

@mironiasty mironiasty commented May 9, 2024

This is follow up on comments from fishjam-dev/membrane-webrtc-android#59 and #15

I've added ktlint to this repository, fixed formatting issues. And also did Code Cleanup.

@mironiasty mironiasty changed the title Code cleanups required after library merge [EX-483] Code cleanups required after library merge May 9, 2024
Copy link
Member

@karkakol karkakol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response to my question. Then approve.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change occured?
If it is on GA should it be reflected in project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just move from using gradlew lintKotlin to ktlint.
I've update README

Copy link
Member

@karkakol karkakol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mironiasty mironiasty merged commit e7d7102 into main May 20, 2024
1 check passed
@mironiasty mironiasty deleted the code-cleanups branch May 20, 2024 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants