Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Update README to use Fishjam (rebranding) #17

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

karkakol
Copy link
Member

@karkakol karkakol commented May 15, 2024

Update README file to use new name - Fishjam

Copy link

@balins balins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to update READMEs only? settings.gradle, JellyfishClient and probably a couple of places more still reference Jellyfish. Wouldn't it make more sense to update all at once and merge once the new org is ready?

README.md Outdated

Android client library for [Jellyfish](https://github.com/jellyfish-dev/jellyfish).
Android client library for [Fishjam](https://github.com/jellyfish-dev/jellyfish).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update the links to point to the new org and repo as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesterday new names were not available, but right now it can be updated too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From today links can be updated safely, i will do it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed yesterday repo code will be updated later.

Copy link
Contributor

@kamil-stasiak kamil-stasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one file left to change: JellyfishClient/module.md

@mironiasty mironiasty changed the title update readme Update README to use Fishjam (rebranding) May 16, 2024
@kamil-stasiak
Copy link
Contributor

Organization and all repositories names changed so we're ready to replace every link

@karkakol karkakol requested a review from balins May 16, 2024 12:05
@@ -1,3 +1,3 @@
# Module JellyfishClient
# Module FishjamClient
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory is still called JellyfishClient. Values in settings.gradle still reference Jellyfish. Please use find and replace and scan through the repo once again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is about *.md files. Variables, names, modules and code will be changed in another PR. Main purpose of pr is to make readme not confusing for people who search it

Copy link

@balins balins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see even the main fishjam repo has only the README updated without touching the code. Weird flex but OK, I won't block you 🤷

@karkakol karkakol merged commit 56a3113 into main May 16, 2024
1 check passed
@karkakol karkakol deleted the karkakol/update_readme branch May 16, 2024 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants