-
Notifications
You must be signed in to change notification settings - Fork 0
Update README to use Fishjam (rebranding) #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to update READMEs only? settings.gradle
, JellyfishClient
and probably a couple of places more still reference Jellyfish
. Wouldn't it make more sense to update all at once and merge once the new org is ready?
README.md
Outdated
|
||
Android client library for [Jellyfish](https://github.com/jellyfish-dev/jellyfish). | ||
Android client library for [Fishjam](https://github.com/jellyfish-dev/jellyfish). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we update the links to point to the new org and repo as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yesterday new names were not available, but right now it can be updated too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From today links can be updated safely, i will do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed yesterday repo code will be updated later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one file left to change: JellyfishClient/module.md
Organization and all repositories names changed so we're ready to replace every link |
@@ -1,3 +1,3 @@ | |||
# Module JellyfishClient | |||
# Module FishjamClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory is still called JellyfishClient
. Values in settings.gradle
still reference Jellyfish
. Please use find and replace and scan through the repo once again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr is about *.md files. Variables, names, modules and code will be changed in another PR. Main purpose of pr is to make readme not confusing for people who search it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see even the main fishjam
repo has only the README updated without touching the code. Weird flex but OK, I won't block you 🤷
Update README file to use new name - Fishjam