This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
rename project source files from jellyfish to fishjam #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mironiasty
reviewed
May 21, 2024
FishjamClient/build.gradle
Outdated
| id 'maven-publish' | ||
|
|
||
| id "kotlin-android" | ||
| } | ||
|
|
||
| android { | ||
| namespace 'com.jellyfishdev.jellyfishclient' | ||
| namespace 'com.fishjam.client' |
There was a problem hiding this comment.
as we are still using fishjam-dev org, maybe we can stick with com.fishjamdev.client?
| @@ -12,15 +12,15 @@ import org.membraneframework.rtc.models.RTCStats | |||
| import org.membraneframework.rtc.utils.Metadata | |||
| import org.webrtc.Logging | |||
|
|
|||
| typealias TrackContext = JellyfishTrackContext | |||
| typealias TrackContext = FishjamTrackContext | |||
There was a problem hiding this comment.
(as part of other PR - I would check if FishjamTrackContext can be removed, as it happened on iOS version)
There was a problem hiding this comment.
I had that in mind. I ticket created.
| .build() | ||
| sendEvent(mediaEvent) | ||
| } | ||
|
|
||
| override fun onTrackAdded(ctx: TrackContext) { | ||
| val trackContext = TrackContext(ctx) | ||
| var trackContext = TrackContext(ctx) |
There was a problem hiding this comment.
Why this change? trackContext is never updated
There was a problem hiding this comment.
ktlint ( not sure why ).
| import org.webrtc.EglBase | ||
| import org.webrtc.audio.AudioDeviceModule | ||
|
|
||
| internal interface MembraneRTCComponent { |
There was a problem hiding this comment.
Is this file still required?
There was a problem hiding this comment.
No, merge from main pulled this file. Deleted.
| @@ -1,7 +1,7 @@ | |||
| package jellyfishdev.jellyfishclient | |||
| package fishjamdev.fishjamclient | |||
There was a problem hiding this comment.
nit:
Suggested change
| package fishjamdev.fishjamclient | |
| package fishjamdev.client |
(to partially match code package name)
mironiasty
approved these changes
May 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.