This repository has been archived by the owner on May 10, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karkakol/add active simulcast encodings #56
Karkakol/add active simulcast encodings #56
Changes from 11 commits
59ad94f
d536baa
f4297bd
1dfa549
d4920c7
d9e820d
38248a6
2658eb7
41988a5
efe6ef5
e0ec3e0
cd9d5d8
0b93cc1
df2d63f
cbf1f6b
9e34387
32ca45d
93a5284
513303e
3b84427
0231704
527dd74
a66946c
7e5e35a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too we have
trackIdToMetadata
andtracks
, if it's user facing class it would be confusingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also an endpoint might be a local endpoint, do we update it in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's user facing it doesn't look nice to me (the
TracksAdded.Data.TrackData
type is too long andTracksAdded
event is not user facing. Consider creating a new type maybe?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary data is removed