This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Update app icon and fishjam logo #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkakol
changed the title
mironiasty
reviewed
May 28, 2024
| "idiom" : "iphone", | ||
| "scale" : "3x", | ||
| "size" : "60x60" | ||
| }, | ||
| { | ||
| "filename" : "1024.png", | ||
| "filename" : "sygnet-color-20.png", |
There was a problem hiding this comment.
I don't think we need to add logo for ipad, as we don't support it on test app
There was a problem hiding this comment.
I created it automatically, with icon set creator. I would leave it.
mironiasty
reviewed
May 28, 2024
There was a problem hiding this comment.
I've tested on iOS and Android. I've noticed two small issues:
- I think that splash screen on Android is now missing (i think it was configured before? 🤔 )
- there is an issue on logo is displayed on blue background. But I'm trying to get some answers on how it should be displayed here correctly
it is but for a short period of time |
mironiasty
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.