Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing #35

Merged
merged 14 commits into from
Nov 5, 2024
Merged

Add testing #35

merged 14 commits into from
Nov 5, 2024

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Nov 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

No code testing.

What is the new behavior?

This pull request includes several changes to enhance the testing framework, update the build and test workflow, and add mock data for API testing. The most important changes are the addition of new tests, updates to the GitHub Actions workflow, and the introduction of mock data for more comprehensive testing.

Testing Enhancements:

Workflow Updates:

  • .github/workflows/main.yml: Updated the workflow to include build steps and added an environment variable for Vercel URL. Also, introduced a new job for running end-to-end tests using Playwright. [1] [2] [3]

Mock Data and API Testing:

Minor Updates:

  • components/theme-toggle.tsx: Added a data-testid attribute to the theme toggle button for easier selection in tests.
  • lib/utils.ts: Added validation checks in the debounce function to ensure the callback is a function and the delay is a positive number.

Other information

None

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
idn-area-map ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:49pm

@fityannugroho fityannugroho merged commit 4c3057d into main Nov 5, 2024
7 checks passed
@fityannugroho fityannugroho deleted the testing branch November 5, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant