add write-back to values-file on Plugin type and Helm WriteBackTargetAnnotation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables write-back to values.yaml files when making use of a Helm Plugin (like Argocd-Vault-Plugin). When both the plugin is used and the
WriteBackTargetAnnotationis set tohelm(orhelm:<values-file-path>) the ArgoCD-Image-Updater will process the plugin like a regular Helm application and updates thevalues.yamlfile in the source path of the Application, after which it will do a GIT write back to make it persistent.