-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add datatype casting and temp deps #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie this PR looks good to go with just a few small requests for updates under the hood and also to adjust one of the validation tests to avoid false failures. This will be good to go once those updates are applied and the source is approved.
packages.yml
Outdated
# version: [">=0.2.0", "<0.3.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_qualtrics_source.git | ||
revision: redshift_datatype_casts | ||
warn-unpinned: false | ||
|
||
# - local: ../Qualtrics/dbt_qualtrics_source | ||
# - local: ../../dbt_qualtrics_source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update before merging
integration_tests/tests/consistency/consistency_qualtrics__contact.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small suggestions!
PR Overview
This PR will address the following Issue/Feature:
#10
This PR will result in the following new package version:
v0.3.0 - source release is breaking
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR #12 folds in upstream updates from the
qualtrics_source
package:Under the Hood
{{ dbt.type_boolean() }}
.qualtrics_union_data
macro to accommdate Redshift's treatment of empty tables.null
row for Redshift destinations.varchar
. This throws errors in dowstream transformations in thezendesk
package. The 1 row will ensure that Redshift will respect the package's datatype casts.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Validation tests added for each end model and they're all passing
If you had to summarize this PR in an emoji, which would it be?
💃