add coalesce to min start_date for date_spine in case stg_distribution_contact is empty #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
@fivetran-jamie thanks for quickly addressing this issue! Given your validations and my review, this looks good to me!
I did have one call out below for a reminder when adding the auto releaser to a repo, and also a suggestion to adjust the wording in the CHANGELOG. Other than that, this looks good to go!
| @@ -0,0 +1,13 @@ | |||
| name: 'auto release' | |||
There was a problem hiding this comment.
Thanks for adding this! FYI don't forget to add the GH_SECRET when you are adding this workflow into a package pipeline.
I just added it for this repo, but it will need to be manually added in the repo settings each time we add this action.
There was a problem hiding this comment.
doh right, thanks for adding it
Co-authored-by: Joe Markiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
internal
What change(s) does this PR introduce?
addresses issue #5
Bug Fix
qualtrics__daily_breakdownalways has a non-null start date, even if you do not have thedistribution_contactsource table, whosemin(created_at)we base the date spine off of.distribution_contacttable is present in your Qualtrics connector(s), the minimum date will be set to2016-01-01.Under the Hood
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
See Hex notebook linked in Height task
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🏂
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.