Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/timestamp-without-time-zone #8

Merged
merged 5 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

env/
Copy link

@fivetran-avinash fivetran-avinash Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add package-lock.yml for good measure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock.yml is already included in the .gitignore.

target/
dbt_modules/
logs/
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# dbt_qualtrics v0.2.0
Copy link

@fivetran-avinash fivetran-avinash Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source Changelog has v.Number.Number in front of the package, transform has v.Number.Number behind it. I know the auto-releaser will usually take care of this but since it's broken, something to watch out for here if you're manually releasing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I just updated the ordering to be consistent with the source and our other packages.


[PR #8](https://github.com/fivetran/dbt_qualtrics/pull/8) includes the following updates:

## 🚨 Breaking Changes: Upstream Changes 🚨
- This release includes an update to the upstream dbt_qualtrics_source dependency which includes breaking changes. These breaking changes included **all** staging model timestamps to be cast using the `dbt.type_timestamp()` macro in order to ensure datatype consistency with timestamp fields.
- For an overview of all breaking changes in the dbt_qualtrics_source data model, please refer to the [respective release notes](https://github.com/fivetran/dbt_qualtrics_source/releases/tag/v0.2.0).

# dbt_qualtrics v0.1.1

[PR #6](https://github.com/fivetran/dbt_qualtrics/pull/6) applies the following changes:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Include the following qualtrics package version in your `packages.yml` file:
```yml
packages:
- package: fivetran/qualtrics
version: [">=0.1.0", "<0.2.0"] # we recommend using ranges to capture non-breaking changes automatically
version: [">=0.2.0", "<0.3.0"] # we recommend using ranges to capture non-breaking changes automatically
```

Do **NOT** include the `qualtrics_source` package in this file. The transformation package itself has a dependency on it and will install the source package as well.
Expand Down Expand Up @@ -166,7 +166,7 @@ This dbt package is dependent on the following dbt packages. Please be aware tha
```yml
packages:
- package: fivetran/qualtrics_source
version: [">=0.1.0", "<0.2.0"]
version: [">=0.2.0", "<0.3.0"]

- package: fivetran/fivetran_utils
version: [">=0.4.0", "<0.5.0"]
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'qualtrics'
version: '0.1.1'
version: '0.2.0'
config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]

Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

12 changes: 11 additions & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'qualtrics_integration_tests'
version: '0.1.1'
version: '0.2.0'
profile: 'integration_tests'
config-version: 2

Expand All @@ -16,6 +16,16 @@ seeds:
qualtrics_integration_tests:
+column_types:
_fivetran_synced: timestamp
directory_unsubscribe_date: timestamp
response_completed_at: timestamp
last_accessed: timestamp
account_creation_date: timestamp
response_started_at: timestamp
account_expiration_date: timestamp
last_login_date: timestamp
password_expiration_date: timestamp
password_last_changed_date: timestamp
unsubscribe_date: timestamp
contact_mailing_list_membership:
+column_types:
unsubscribe_date: timestamp
Expand Down
7 changes: 5 additions & 2 deletions packages.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
packages:
- package: fivetran/qualtrics_source
version: [">=0.1.0", "<0.2.0"]
# - package: fivetran/qualtrics_source
# version: [">=0.2.0", "<0.3.0"]
- git: https://github.com/fivetran/dbt_qualtrics_source.git
revision: bugfix/timestamp-without-time-zone
warn-unpinned: false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will swap before release

fivetran-joemarkiewicz marked this conversation as resolved.
Show resolved Hide resolved