Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
fivetran-reneeli committed May 15, 2024
1 parent 2383bdc commit 7337bc9
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,13 @@
- Corrects the misspelled `customer_vendor_webiste` field to `customer_vendor_website` in `quickbooks__ap_ar_enhanced`.

## Bug Fixes
- Updates the [quickbooks__profit_and_loss](https://github.com/fivetran/dbt_quickbooks/blob/main/models/quickbooks__profit_and_loss.sql) and [quickbooks__balance_sheet](https://github.com/fivetran/dbt_quickbooks/blob/main/models/quickbooks__balance_sheet.sql) models to include both `period_first_day` and `period_last_day`. This allows users to have greater flexibility in choosing which date to aggregate records upon.
- Updates the logic for the `amount` field in [int_quickbooks__invoice_double_entry](https://github.com/fivetran/dbt_quickbooks/blob/main/models/double_entry_transactions/int_quickbooks__invoice_double_entry.sql) to use `invoice.total_amount` only on the condition when a bundle is associated with the invoice and `invoice.total_amount` is 0, otherwise `invoice_lines.amount` is used.
- This avoids double counting when aggregating invoice_line items and accounts for the edge cases where a bundle_id is involved.

## Feature Updates
- Updates the [quickbooks__profit_and_loss](https://github.com/fivetran/dbt_quickbooks/blob/main/models/quickbooks__profit_and_loss.sql) and [quickbooks__balance_sheet](https://github.com/fivetran/dbt_quickbooks/blob/main/models/quickbooks__balance_sheet.sql) models to include both `period_first_day` and `period_last_day` in addition to `calendar_date`. This allows users to have greater flexibility in choosing which date to aggregate records upon.
- Please note `calendar_date` is slotted to be deprecated, and the fields `period_first_day` and `period_last_day` are both offered as replacements, depending on how your company performs their financial reporting.

# dbt_quickbooks v0.12.4
[PR #123](https://github.com/fivetran/dbt_quickbooks/pull/123) includes the following updates:

Expand Down
2 changes: 1 addition & 1 deletion models/docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ The type of account associated
{% enddocs %}

{% docs calendar_date %}
Timestamp of the first calendar date of the month.
Timestamp of the first calendar date of the month. This is slated to be deprecated, and the fields `period_first_day` and `period_last_day` are both offered as replacements, depending on how your company performs their financial reporting.
{% enddocs calendar_date %}

{% docs is_sub_account %}
Expand Down
2 changes: 1 addition & 1 deletion models/quickbooks__balance_sheet.sql
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ with general_ledger_by_period as (

final as (
select
period_first_day as calendar_date,
period_first_day as calendar_date, -- Slated to be deprecated; we recommend using `period_first_day` or `period_last_day`
period_first_day,
period_last_day,
source_relation,
Expand Down
4 changes: 1 addition & 3 deletions models/quickbooks__profit_and_loss.sql
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ with general_ledger_by_period as (

final as (
select
period_first_day as calendar_date,
period_first_day,
period_last_day,
period_first_day as calendar_date, -- Slated to be deprecated; we recommend using `period_first_day` or `period_last_day`
source_relation,
account_class,
class_id,
Expand Down

0 comments on commit 7337bc9

Please sign in to comment.