-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MUI to version 5 WIP #1205
Open
1v4n4
wants to merge
13
commits into
main
Choose a base branch
from
upgrade/mui6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is reduced in mui5)
@tttp take a look, please. It is MUI 5, and everything seems to be working. If OK, I'd like to go to MUI 6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are made using codemod. I reviewed each one and removed/fixed what was wrong.
The changes (not all version 5 changes, just implemented in this PR):
imports from @mui
previous default button size is now "large"
theme.palette.type key is now theme.palette.mode
overriding components style:
justify is justifyContent
- <Grid container justify="flex-end">
+ <Grid container justifyContent="flex-end">
Circle is circular:
- <Skeleton animation="wave" variant="circle" />
+ <Skeleton animation="wave" variant="circular" />