Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MUI to version 5 WIP #1205

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Update MUI to version 5 WIP #1205

wants to merge 13 commits into from

Conversation

1v4n4
Copy link
Member

@1v4n4 1v4n4 commented Jun 14, 2023

Most of the changes are made using codemod. I reviewed each one and removed/fixed what was wrong.
The changes (not all version 5 changes, just implemented in this PR):

  • imports from @mui

  • previous default button size is now "large"

  • theme.palette.type key is now theme.palette.mode

  • overriding components style:

            -  overrides: {
            -    MuiButton: {
            -      root: { padding: 0 },
            -    },
            -  },
            +  components: {
            +    MuiButton: {
            +      styleOverrides: {
            +        root: { padding: 0 },
            +      },
            +    },
            +  },
    
  • justify is justifyContent
    - <Grid container justify="flex-end">
    + <Grid container justifyContent="flex-end">

  • Circle is circular:
    - <Skeleton animation="wave" variant="circle" />
    + <Skeleton animation="wave" variant="circular" />

@1v4n4 1v4n4 changed the title Update MUI to version 6 Update MUI to version 6 WIP Jun 14, 2023
@1v4n4
Copy link
Member Author

1v4n4 commented Jun 14, 2023

@tttp take a look, please. It is MUI 5, and everything seems to be working. If OK, I'd like to go to MUI 6.

@tttp
Copy link
Member

tttp commented Jul 1, 2023

There is a problem with the size of the bundle

on mui5:
/index.js 1.2Mb

image

on mui4:
/index.js 665.2kb

image

the widget is doubling the size, this sadly won't be acceptable to upgrade as is, let's try to understand what's happening

@tttp tttp changed the title Update MUI to version 6 WIP Update MUI to version 5 WIP Jul 1, 2023
@tttp
Copy link
Member

tttp commented Jul 6, 2023

@tttp tttp added help wanted Extra attention is needed do not merge labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants