Migration completed of testing unit from GTest to Catch2. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think I am the right reviewer, I don't know this repository. |
nicolas-slusarenko
requested review from
hgaiser
and removed request for
enricoliscio
hgaiser
reviewed
Aug 22, 2019
| @@ -7,13 +7,16 @@ set(CMAKE_CXX_EXTENSIONS OFF) | |||
|
|
|||
| add_compile_options(-Wall -Wextra -Wpedantic -Werror) | |||
|
|
|||
| find_package(catkin REQUIRED) | |||
| find_package(catkin REQUIRED COMPONENTS | |||
| dr_ros | |||
test/geometry.cpp
Outdated
| return RUN_ALL_TESTS(); | ||
| namespace { | ||
| void requireEqual(float const & a, float const & b) | ||
| { |
test/polynomial.cpp
Outdated
| return RUN_ALL_TESTS(); | ||
| namespace { | ||
| void requireEqual(float const & a, float const & b) | ||
| { |
|
Some small comments, but looks good in general. The tests seem to fail though: https://buildbot.fizyr.com/#/builders/234/builds/684 |
added 6 commits
August 26, 2019 14:11
hgaiser
reviewed
Sep 9, 2019
test/resource.cpp
Outdated
| TEST(ResourceTest, localFileUrl) { | ||
| ASSERT_EQ("/test.file", rosUrlToPath("file:///test.file")); | ||
| TEST_CASE("ResourceTest -- packageUrl", "packageUrl") { | ||
| std::cout << "first:" << ros::package::getPath("dr_ros") << "\n"; |
added 7 commits
October 29, 2019 17:02
|
@ekrikelis please check this issue in Buildbot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration completed of testing unit from GTest to Catch2.
Submitted for your review @enricoliscio