Merge pull request #7627 from fjordllc/bug/not-receive-mail-notificat…

…ion-of-question

プラクティス未選択で質問を作成した場合にメール通知が届かないバグの修正

app/mailers/activity_mailer.rb

@@ -124,6 +124,7 @@ def came_question(args = {})
     @question ||= args[:question]
 
     @user = @receiver
+    @title = @question.practice.present? ? "「#{@question.practice.title}」についての質問がありました。" : '質問がありました。'
     @link_url = notification_redirector_url(
       link: "/questions/#{@question.id}",
       kind: Notification.kinds[:came_question]

app/views/activity_mailer/came_question.html.slim

@@ -1,5 +1,5 @@
 = render '/notification_mailer/notification_mailer_template',
-  title: "「#{@question.practice.title}」についての質問がありました。",
+  title: @title,
   link_url: @link_url,
   link_text: '質問へ' do
   p #{@question.user.login_name}さんから質問がありました。アドバイスや回答を投稿しよう！！

test/mailers/activity_mailer_test.rb

@@ -264,6 +264,26 @@ class ActivityMailerTest < ActionMailer::TestCase
     assert_match(%r{<a .+ href="http://localhost:3000/notification/redirector\?#{query}">質問へ</a>}, email.body.to_s)
   end
 
+  test 'came_question with no practice' do
+    question = questions(:question14)
+    user = question.user
+    mentor = users(:komagata)
+
+    ActivityMailer.came_question(
+      sender: user,
+      receiver: mentor,
+      question:
+    ).deliver_now
+
+    assert_not ActionMailer::Base.deliveries.empty?
+    email = ActionMailer::Base.deliveries.last
+    query = CGI.escapeHTML({ kind: 6, link: "/questions/#{question.id}" }.to_param)
+    assert_equal ['[email protected]'], email.from
+    assert_equal ['[email protected]'], email.to
+    assert_equal '[FBC] kimuraさんから質問「プラクティスを選択せずに登録したテストの質問」が投稿されました。', email.subject
+    assert_match(%r{<a .+ href="http://localhost:3000/notification/redirector\?#{query}">質問へ</a>}, email.body.to_s)
+  end
+
   test 'mentioned' do
     mentionable = comments(:comment9)
     mentioned = notifications(:notification_mentioned)