Skip to content

Commit

Permalink
Merge pull request #7456 from fjordllc/feature/added-punctuation-end-…
Browse files Browse the repository at this point in the history
…of-notice-of-submission-update

提出物を更新した時の通知の末尾に句読点を追加、他のものと統一する形にした
  • Loading branch information
komagata authored Mar 9, 2024
2 parents 4c6bff8 + 4f1748c commit 81a6942
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/notifiers/activity_notifier.rb
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def product_update(params = {})
receiver = params[:receiver]

notification(
body: "#{product.user.login_name}さんの「#{product.practice.title}」の提出物が更新されました",
body: "#{product.user.login_name}さんの「#{product.practice.title}」の提出物が更新されました",
kind: :product_update,
receiver:,
sender: product.sender,
Expand Down
4 changes: 2 additions & 2 deletions test/system/notification/products_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Notification::ProductsTest < ApplicationSystemTestCase
visit_with_auth '/notifications', 'komagata'

within first('.card-list-item.is-unread') do
assert_text "kimuraさんの「#{product.practice.title}」の提出物が更新されました"
assert_text "kimuraさんの「#{product.practice.title}」の提出物が更新されました"
end
end

Expand All @@ -64,7 +64,7 @@ class Notification::ProductsTest < ApplicationSystemTestCase
visit_with_auth '/notifications', 'komagata'

within first('.card-list-item.is-unread') do
assert_text "hajimeさんの「#{product.practice.title}」の提出物が更新されました"
assert_text "hajimeさんの「#{product.practice.title}」の提出物が更新されました"
end
end

Expand Down

0 comments on commit 81a6942

Please sign in to comment.