Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

提出物を更新した時の通知の末尾に句読点を追加、他のものと統一する形にした #7456

Merged
merged 1 commit into from
Mar 9, 2024
Merged

提出物を更新した時の通知の末尾に句読点を追加、他のものと統一する形にした #7456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/notifiers/activity_notifier.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def product_update(params = {})
receiver = params[:receiver]

notification(
body: "#{product.user.login_name}さんの「#{product.practice.title}」の提出物が更新されました",
body: "#{product.user.login_name}さんの「#{product.practice.title}」の提出物が更新されました。",
kind: :product_update,
receiver:,
sender: product.sender,
Expand Down
4 changes: 2 additions & 2 deletions test/system/notification/products_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Notification::ProductsTest < ApplicationSystemTestCase
visit_with_auth '/notifications', 'komagata'

within first('.card-list-item.is-unread') do
assert_text "kimuraさんの「#{product.practice.title}」の提出物が更新されました"
assert_text "kimuraさんの「#{product.practice.title}」の提出物が更新されました。"
end
end

Expand All @@ -64,7 +64,7 @@ class Notification::ProductsTest < ApplicationSystemTestCase
visit_with_auth '/notifications', 'komagata'

within first('.card-list-item.is-unread') do
assert_text "hajimeさんの「#{product.practice.title}」の提出物が更新されました"
assert_text "hajimeさんの「#{product.practice.title}」の提出物が更新されました。"
end
end

Expand Down