Release 2024-06-30 11:36:40 +0000 #7904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
commented
Jun 29, 2024
•
github-actions
bot
commented
- [6/30 夜にマージ] フロントエンドエンジニアコースオープン #7793 @machida
- Update developer_mozilla_org.yml to remove "polyfill.io" string #7903 @JunichiIto
サインアップページにコース選択を配置した 別ページでコース一覧ページを作成した
allだとどう並ぶかわからないので変更した
find_default_courseは他でも使いそうなのでモデルに移動した
タイトルが複数箇所で使われているので定数化してまとめた メソッド名のfind_は不要なため変更した
Courseクラス内でDEFAULT_COURSEを直接参照するのではなく、パブリックメソッドを通じてアクセスできるようにした
Signupだけで必要なものではないので変更した
PR#7887で変更しており競合があったため変更した
Helper名は複数形なので修正した
h3のテキストは長くないので、|を入れなくても問題ない
To eliminate polyfill.io string
Update developer_mozilla_org.yml to remove "polyfill.io" string
github-actions
bot
changed the title
[6/30 夜にマージ] フロントエンドエンジニアコースオープン
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.