-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2024-07-17 12:36:55 +0000 #7928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
commented
Jul 4, 2024
•
edited by reckyy
Loading
edited by reckyy
- ニコニコカレンダーを非Vue化 #7443 @reckyy
- 企業一覧ページから各企業のアドバイザー・現役生のページへ飛べるようにした #7479 @mousu-a
- お問い合わせがあったら管理者に通知する #7510 @goruchanchan
- ブログを更新するたびに通知されていたバグを初回公開時のみ通知されるように修正 #7889 @motohiro-mm
- bookmark削除のトーストの文言を日本語に変更 #7891 @su-su-su-su
- 外部公開ブログに atom フィードを追加 #7899 @nishitatsu-dev
- メッセージに不要な文字が入っていたのを修正 #7927 @machida
- ポートフォリオページのタイトルタグ文言変更 #7930 @Judeeeee
- レイアウト崩れの修正 #7938 @machida
- development環境でnewspaperの設定が2回走るのを修正 #7939 @komagata
- ポートフォリオ個別のリンクのデザイン崩れ修正 #7949 @machida
- 「フォローする」ボタンがメッセージより手前に表示されてしまう #7794 を修正 #7951 @machida
その時々で、エラーの出ない書き方を採用していたが、直してみると普通に表示できたので統一
それに伴いparamsの受け取り方も変更
また、以下の修正も追加で行った calendar_with_reportsメソッドの第二引数をcurrent_dateに変更(後にdateという変数を登場させたかったため)
…letion bookmark削除のトーストの文言を日本語に変更
github-actions
bot
changed the title
Release 2024-07-15 18:12:34 +0000
Release 2024-07-15 18:13:57 +0000
Jul 15, 2024
また、それに伴いテストも一部同時に行うようにした。component_test内のコメント参照。
viewcomponentの移行に伴い、CalendarHelperを削除した際に削除し忘れていた
…rs-for-company-on-companies-page 企業一覧ページから各企業のアドバイザー・現役生のページへ飛べるようにした
github-actions
bot
changed the title
Release 2024-07-15 18:13:57 +0000
Release 2024-07-16 09:43:28 +0000
Jul 16, 2024
…e-conversion ニコニコカレンダーを非Vue化
github-actions
bot
changed the title
Release 2024-07-16 09:43:28 +0000
Release 2024-07-17 12:36:55 +0000
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.