ポートフォリオページの見出し文言変更 #7929
Merged
ポートフォリオページの見出し文言変更 #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
お疲れ様です！ |
|
承知いたしました！ あと、このPRのdescription内のScreenshot画像が現在見れなかったので確認をお願いいたします🙏 |
|
@motohiro-mm
ご指摘ありがとうございます！ |
|
Screenshot見れました！ありがとうございます👍 |
motohiro-mm
approved these changes
Jul 8, 2024
|
@motohiro-mm |
|
お疲れ様ですー！ |
komagata
reviewed
Jul 15, 2024
app/views/works/index.html.slim
Outdated
| @@ -6,7 +6,7 @@ header.page-header | |||
| .page-header__inner | |||
| .page-header__start | |||
| h2.page-header__title | |||
| = title | |||
| |みんなのポートフォリオ | |||
There was a problem hiding this comment.
全体で下記のようにスペースを開けているので同じようにしていただければありがたいです〜
Suggested change
| |みんなのポートフォリオ | |
| | みんなのポートフォリオ |
Judeeeee
force-pushed
the
bug/update-portfolio-headings-text
branch
from
eabae4a to
e214316
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
ポートフォリオ一覧ページの見出し文言を変更しました。
変更確認方法
bug/update-portfolio-headings-textをローカルに取り込むforeman start -f Procfile.devでローカルサーバーを立ち上げる確認事項
ページの見出しが
みんなのポートフォリオになっているScreenshot
変更前
変更後