Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

「5. ActiveStorage で画像アップロードを実装する」の差分 / 「6. コメントを付けられるようにする」のスタート地点 #4

Open
wants to merge 14 commits into
base: 05-user_icon
Choose a base branch
from

Conversation

JunichiIto
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@JunichiIto JunichiIto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今のままだとN+1問題が起きそうなので、そこも解消してみてください〜。

<strong><%= User.human_attribute_name(:avatar) %>:</strong>
<% if user.avatar.attached? %>
<br>
<%= image_tag user.avatar.variant(:thumb) %>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一覧画面でN+1問題が発生しないように改善してみてください。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant