GH-3488: Support for writing a ColumnCorpus instance to files #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelseagzr
force-pushed
the
gh-3488/save-column-corpus-to-files
branch
from
1c8f4ad to
d1ce766
Compare
mattb-zip
approved these changes
Jul 11, 2024
chelseagzr
force-pushed
the
gh-3488/save-column-corpus-to-files
branch
from
a8bc603 to
6941510
Compare
alanakbik
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks for adding this!
One issue is that this adds many public methods to ColumnCorpus and ColumnDataset, which may be confusing to users since most of these are used only for a single functionality. I suggest leaving only the respective "save" and "load" method public (since these are the ones that users will call), and marking all others as internal.
MattGPT-ai
approved these changes
Jul 23, 2024
|
@alanakbik Could you please review the new changes when you have a chance? Thank you! |
|
@alanakbik Could you please review the new changes when you have a chance? Thank you! |
|
hello @chelseagzr very sorry it took so long! I updated your branch for our current master, but one of the imports got lost. Could you add it back in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #3488
Current limitations:
write_to_directorywhitespace_afterattribute of tokens will not be preserved after saving the corpus to files; onlydefault_whitespace_afterattribute of datasets will be preserved.