Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Skip broken drawRawAtlas tests [flame_3d] #3299

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

luanpotter
Copy link
Member

@luanpotter luanpotter commented Sep 11, 2024

Description

Skip broken drawRawAtlas tests.
This has nothing to do with Flame 3D - just some issue on Flutter main.
In order to facilitate our build, this PR temporarily skips those tests.
That makes our build fully green :)

Obviously this should not be merged into main.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter changed the title chore: Skip broken drawRawAtlas tests chore: Skip broken drawRawAtlas tests [flame_3d] Sep 11, 2024
@luanpotter luanpotter marked this pull request as ready for review September 12, 2024 13:24
@luanpotter luanpotter requested a review from spydon September 12, 2024 13:24
@spydon spydon changed the title chore: Skip broken drawRawAtlas tests [flame_3d] test: Skip broken drawRawAtlas tests [flame_3d] Sep 12, 2024
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make an issue to make sure we don't forget to revert this before merging to main?

@luanpotter
Copy link
Member Author

Done: #3301

@luanpotter luanpotter merged commit 5cc269f into flame_3d Sep 12, 2024
10 checks passed
@luanpotter luanpotter deleted the luan.skip-tests branch September 12, 2024 14:14
luanpotter added a commit that referenced this pull request Oct 15, 2024
Skip broken `drawRawAtlas` tests.
This has nothing to do with Flame 3D - just some issue on Flutter main.
In order to facilitate our build, this PR temporarily skips those tests.
That makes our build fully green :)

Obviously this should not be merged into main.
luanpotter added a commit that referenced this pull request Dec 11, 2024
Skip broken `drawRawAtlas` tests.
This has nothing to do with Flame 3D - just some issue on Flutter main.
In order to facilitate our build, this PR temporarily skips those tests.
That makes our build fully green :)

Obviously this should not be merged into main.
luanpotter added a commit that referenced this pull request Dec 11, 2024
Skip broken `drawRawAtlas` tests.
This has nothing to do with Flame 3D - just some issue on Flutter main.
In order to facilitate our build, this PR temporarily skips those tests.
That makes our build fully green :)

Obviously this should not be merged into main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants