feat: Add validation against passing both color and foreground to InlineTextStyle #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Dec 30, 2024
| @@ -84,10 +87,15 @@ class InlineTextStyle extends FlameTextStyle { | |||
| } | |||
|
|
|||
| TextStyle asTextStyle() { | |||
| final fontSize = this.fontSize; | |||
| if (fontSize == null) { | |||
| throw Exception('fontSize must be set'); | |||
There was a problem hiding this comment.
I plan on working on standardizing asserts, exceptions and tests thereof on a followup, so I am not making any particular choice in this PR.
There was a problem hiding this comment.
But you did make the choice of casting an unspecified exception, it didn't have that before right? Which is like the worst of both worlds 😅
Or are you doing the refactoring like today? Then I guess it is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validation against passing both color and foreground to InlineTextStyle.
Note: I plan on working on standardizing asserts, exceptions and tests thereof on a followup, so I am not focusing on this particular issue here.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?