Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix melos/workspace scripts to be able to lint monorepo locally #3447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix melos/workspace scripts to be able to lint monorepo locally #3447

wants to merge 1 commit into from

Conversation

luanpotter
Copy link
Member

Description

Fix melos/workspace scripts to be able to lint monorepo locally

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter requested a review from spydon January 15, 2025 18:40
@github-actions GitHub Actions
Copy link
Contributor

Benchmark Results

Package flame:

Benchmarks Current Branch
[luan.fix-melos]		 Base Branch
[main]		 Diff
Render Components Benchmark 1198.227 μs 1205.385 μs 🟢 -0.594 %
Updating Components Benchmark 259933.000 μs 276409.750 μs 🟢 -5.961 %

Benchmarks provided with 💙 by Dart Benchmark Action.

@luanpotter luanpotter marked this pull request as ready for review January 15, 2025 20:39
spydon
spydon reviewed Jan 17, 2025
View reviewed changes
pubspec.yaml
run: melos exec dart analyze .
description: Run `dart analyze` for all packages.

format:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format should still exist as a default I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luanpotter @spydon