Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Commit

Permalink
Merge pull request #4 from flame-engine/luan.fix-formatting
Browse files Browse the repository at this point in the history
Fix formatting
  • Loading branch information
luanpotter authored May 28, 2020
2 parents 926baf8 + e896053 commit a8acade
Show file tree
Hide file tree
Showing 6 changed files with 117 additions and 13 deletions.
18 changes: 18 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Build

on: push

jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- uses: actions/setup-java@v1
with:
java-version: '12.x'
- uses: subosito/flutter-action@v1
with:
channel: 'stable'
- run: flutter pub get
- run: ./scripts/lint.sh
68 changes: 68 additions & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
# Source of linter options:
# http://dart-lang.github.io/linter/lints/options/options.html

linter:
rules:
- always_declare_return_types
- always_put_control_body_on_new_line
- always_require_non_null_named_parameters
- annotate_overrides
- avoid_empty_else
- avoid_field_initializers_in_const_classes
- avoid_init_to_null
- avoid_null_checks_in_equality_operators
- avoid_relative_lib_imports
- avoid_return_types_on_setters
- avoid_slow_async_io
- await_only_futures
- camel_case_types
- cancel_subscriptions
- control_flow_in_finally
- empty_catches
- empty_constructor_bodies
- empty_statements
- hash_and_equals
- implementation_imports
- iterable_contains_unrelated_type
- library_names
- library_prefixes
- list_remove_unrelated_type
- no_adjacent_strings_in_list
- no_duplicate_case_values
- non_constant_identifier_names
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_adjacent_string_concatenation
- prefer_asserts_in_initializer_lists
- prefer_collection_literals
- prefer_conditional_assignment
- prefer_const_constructors
- prefer_const_declarations
- prefer_const_literals_to_create_immutables
- prefer_contains
- prefer_equal_for_default_values
- prefer_final_fields
- prefer_final_locals
- prefer_foreach
- prefer_initializing_formals
- prefer_is_empty
- prefer_is_not_empty
- prefer_typing_uninitialized_variables
- recursive_getters
- slash_for_doc_comments
- sort_unnamed_constructors_first
- test_types_in_equals
- throw_in_finally
- type_init_formals
- unnecessary_brace_in_string_interps
- unnecessary_getters_setters
- unnecessary_null_aware_assignments
- unnecessary_null_in_if_null_operators
- unnecessary_overrides
- unnecessary_parenthesis
- unnecessary_this
- unrelated_type_equality_checks
- use_rethrow_when_possible
- unnecessary_new

18 changes: 9 additions & 9 deletions example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,16 @@ class _MyAppState extends State<MyApp> {
Text('Is connected on: $_isConnected\n'),
Text(_lastEvent),
RaisedButton(
child: Text("Try connection again"),
onPressed: () async {
final isConnected = await checkIsConnected();
setState(() {
_isConnected = isConnected;
});
}
child: Text('Try connection again'),
onPressed: () async {
final isConnected = await checkIsConnected();
setState(() {
_isConnected = isConnected;
});
},
),
]
)
],
),
),
),
);
Expand Down
7 changes: 3 additions & 4 deletions lib/flame_gamepad.dart
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ class FlameGamepad {

void setListener(GamepadListener gamepadListener) {
listener = (RawKeyEvent e) {
String evtType =
final evtType =
e is RawKeyDownEvent ? GAMEPAD_BUTTON_DOWN : GAMEPAD_BUTTON_UP;

if (e.data is RawKeyEventDataAndroid) {
RawKeyEventDataAndroid androidEvent = e.data as RawKeyEventDataAndroid;
final androidEvent = e.data as RawKeyEventDataAndroid;

String key = ANDROID_MAPPING[androidEvent.keyCode];
final String key = ANDROID_MAPPING[androidEvent.keyCode];
if (key != null) {
gamepadListener(evtType, key);
}
Expand All @@ -77,4 +77,3 @@ class FlameGamepad {
RawKeyboard.instance.removeListener(listener);
}
}

3 changes: 3 additions & 0 deletions scripts/fix.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/bash -e

flutter format .
16 changes: 16 additions & 0 deletions scripts/lint.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/bin/bash -e

if [[ $(flutter format -n .) ]]; then
echo "flutter format issue"
exit 1
fi

result=`dartanalyzer lib/`
if ! echo "$result" | grep -q "No issues found!"; then
echo "$result"
echo "dartanalyzer issue"
exit 1
fi

echo "success"
exit 0

0 comments on commit a8acade

Please sign in to comment.