fix: Update GamepadsDarwinPlugin.swift to conditionally reference sfSymbolsName #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymbolsName depending on macOS version. See Issue #18
|
@markvideon You might want to resolve the markdown-lint check that failed when you get a chance. |
This PR doesn't modify any README files, I consider it a seperate issue |
Yeah, I just noticed that. I on the other hand submitted a PR with a modified README.md and it's passed. Agree on it being a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #18, sfSymbolsName is only available in macOS 11.0 or newer, but the getValues method references it without use of conditional compilation. The result is that the example project cannot be compiled on macOS.
The proposed change provides a default label for each type of GCControllerElement (e.g. "Unknown button" for a button) which is then overridden by the sfSymbolsName property if it is available.