feat: Improve navigation between all the pages #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
commented
Jul 2, 2023
| ); | ||
| const GamepadKey selectButton = GamepadButtonKey( | ||
| linuxKeyName: '6', | ||
| macosKeyName: '???', |
There was a problem hiding this comment.
@erickzanardo could you please fill up later please
spydon
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
Note: we cannot use push/pop because the per-page gamepad listeners do not work.
For now I am replacing everything with pushReplcement, since it works better.
We dont have mobile support for now anyway.
In the future we would need to have a single gamepad listener in the root and do the drill down to the current page ourselves as flutter doesn't support that.