Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle packer 3.0!! #21

Merged
merged 15 commits into from
Aug 21, 2024
Merged

Conversation

Brelee2222
Copy link
Contributor

No description provided.

@Brelee2222 Brelee2222 marked this pull request as draft May 24, 2024 03:14
Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR honestly looks good, but I'm super sick right now so I'm going to get someone else to review it too. I didn't check any of your math, you know a lot more about it than I do at the moment, also I think you're TS skills are Proficient + but I need confirmation that this actually works and there are some things that give me cause for concern. I would test it on my device, but I don't have it setup with all the CLUCK config thingies and don't feel like doing so while I'm sick. When either the other reviewer or yourself shows me a video of this working, I'll fully support a merge.

src/frontend/dash/busBubble.ts Outdated Show resolved Hide resolved
src/frontend/dash/busBubble.ts Outdated Show resolved Hide resolved
src/frontend/dash/busBubble.ts Outdated Show resolved Hide resolved
src/frontend/dash/busBubble.ts Outdated Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Outdated Show resolved Hide resolved
src/frontend/dash/index.ts Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Show resolved Hide resolved
@azaleacolburn azaleacolburn requested a review from rutmanz June 13, 2024 12:59
Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main things are what @Ewie21 and I wrote on slack:

  • Member circles should be closer together
  • Clock circle should be bigger
  • Member circles also shouldn’t jump back to their original position when they’re re-rendered.
  • Size disparity too extreme

I'd also like to caution against leaving in code and comments that don't make sense or that don't have a purpose just because they were there before.

src/frontend/dash/busBubble.ts Outdated Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Outdated Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Outdated Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Outdated Show resolved Hide resolved
src/frontend/dash/busBubble.ts Outdated Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Show resolved Hide resolved
src/frontend/dash/circlePacker.ts Show resolved Hide resolved
@azaleacolburn
Copy link
Member

I don't think everything was addressed in your latest commit, I left reminders in the relevant conversations. Also, was busBubble.ts being used at all, or was it just duplicate code? If it was duplicate code, is there a benefit in your opinion to keeping it extracted in a separate file?

Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through and resolved the comments that were no longer relevant, but there are still 3 left that need changes or further discussion

@azaleacolburn azaleacolburn requested a review from rutmanz July 2, 2024 16:21
@rutmanz rutmanz marked this pull request as ready for review July 5, 2024 20:40
@azaleacolburn azaleacolburn removed their assignment Aug 20, 2024
@azaleacolburn azaleacolburn added the rewrite An overhaul of one or more areas of CLUCK label Aug 20, 2024
@rutmanz rutmanz added enhancement New feature or request and removed rewrite An overhaul of one or more areas of CLUCK labels Aug 20, 2024
@rutmanz rutmanz requested a review from azaleacolburn August 21, 2024 17:58
@azaleacolburn azaleacolburn merged commit 3e30159 into flamingchickens1540:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants