This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Auto when lined up with apriltag at start #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-ChickenPhotonCamera -DriveToAprilTag -WaitUntilAprilTagIsWithinXMeters -WaitUntilCanSeeAprilTag
-DriveForwardRampedForever
Like a fucken beast Let us goot 😎 🔥
…amp to ramping enabled
rutmanz
reviewed
Dec 15, 2022
There was a problem hiding this comment.
The auto changes look nice, however I'm not sure what's going on with the drive train limiting. Your robot isn't all that tippy in the first place, and I'm not convinced that spending any significant amount of time trying to debug all of this would be worth it. I'd say try this and if it works, great, but if it doesn't, just switch them to coast mode and call it a day.
src/main/java/org/team1540/elmo/subsystems/drivetrain/DriveTrain.java
Outdated
Show resolved
Hide resolved
rutmanz
previously approved these changes
Dec 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.