fix: Don't allow edit/delete for CRD created notifications #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mainawycliffe can we do the same for notifications ? |
|
@moshloop you mean connections? |
mainawycliffe
force-pushed
the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
from
bef07f6
to
49f43b6
Compare
mainawycliffe
force-pushed
the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
from
49f43b6
to
5d9ba58
Compare
|
@mainawycliffe we seem to have lost the test connection on on CRD's |
mainawycliffe
force-pushed
the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
from
5d9ba58
to
76a1070
Compare
mainawycliffe
force-pushed
the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
from
76a1070
to
50ffa89
Compare
mainawycliffe
force-pushed
the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
from
50ffa89
to
b95ae70
Compare
mainawycliffe
force-pushed
the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
from
b95ae70
to
de8e338
Compare
mainawycliffe
force-pushed
the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
from
de8e338
to
a72fb76
Compare
mainawycliffe
force-pushed
the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
from
a72fb76
to
2fee999
Compare
moshloop
deleted the
2260-Dont-allow-editdelete-for-CRD-created-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2260