feat: add Notification List with settings and selenced tabs #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mainawycliffe
changed the title
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
469dec6
to
73c3a94
Compare
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
73c3a94
to
7efb449
Compare
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
7efb449
to
8ca6721
Compare
|
The count only makes sense for unsent notifications (silenced, repeat interval) Maybe the count should be besides the status like we have for configs.
Likewise for the |
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
7927cac
to
c153428
Compare
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
c153428
to
2f5fdb5
Compare
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
6565429
to
085c79c
Compare
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
8f89d46
to
3701dfb
Compare
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
328574c
to
f01b096
Compare
mainawycliffe
changed the title
|
@mainawycliffe - Can we add an icon and modal for the errors ? - The status filter also needs to be fixed |
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
1750cce
to
744fd56
Compare
Fixes #2286 feat: implement the notification silencing fully Fixes #2286 chore: remove notification rules fix: pull notifications from send history summary fix: improve the notifications fix: fix missing link for notification in some pages fix: wire through the filters refactor: use arrays for long select query strings refactor: move NotificationRule type to types directory chore: cleanup the tables and fix issue during testing fix: fix filters not working fix: fix icon sizes chore: improve statuses and modal and minor ui issues
mainawycliffe
force-pushed
the
2286-Notification-List
branch
from
744fd56
to
bff2734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2286