Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding admission hook operation "DELETE" and "CONNECT" to allowed list. #527

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

Dmitrykob
Copy link
Contributor

@Dmitrykob Dmitrykob commented Sep 13, 2023

Overview

Webhook for DELETE and CONNECT operations results in an error:

MAIN Fatal: initialize hook manager: creating hook '160-multitenancy-manager/webhooks/validating/projectType': load hook '160-multitenancy-manager/webhooks/validating/projectType' config: 1 error occurred:\n\t* kubernetesValidating.rules.operations should be one of [CREATE UPDATE *]

What this PR does / why we need it

Close to deckhouse/deckhouse#5744. It permit to use DELETE and CONNECT operations in validation webhooks.

For reviewer

Requires new tag release

dmitry.koba added 2 commits September 11, 2023 18:34
…CONNECT" to allowed list.

Signed-off-by: dmitry.koba <[email protected]>
+
Signed-off-by: dmitry.koba <[email protected]>
@Dmitrykob Dmitrykob added the publish/image/dev Build and push dev image using PR number as docker tag label Sep 13, 2023
@github-actions github-actions bot removed the publish/image/dev Build and push dev image using PR number as docker tag label Sep 13, 2023
@Dmitrykob Dmitrykob added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 19, 2023
@Dmitrykob Dmitrykob changed the title 5316 projecttype is used [multitenancy-manager] Adding admission hook operation "DELETE" and "CONNECT" to allowed list. Sep 19, 2023
@Dmitrykob Dmitrykob requested a review from yalosev September 19, 2023 17:03
@Dmitrykob Dmitrykob marked this pull request as ready for review September 19, 2023 17:03
@yalosev yalosev merged commit f6471e2 into main Sep 21, 2023
@yalosev yalosev deleted the 5316-projecttype-is-used branch September 21, 2023 07:30
@yalosev yalosev changed the title [multitenancy-manager] Adding admission hook operation "DELETE" and "CONNECT" to allowed list. Adding admission hook operation "DELETE" and "CONNECT" to allowed list. Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants