Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty config hook section #541

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Handle empty config hook section #541

merged 1 commit into from
Oct 20, 2023

Conversation

yalosev
Copy link
Contributor

@yalosev yalosev commented Oct 20, 2023

Overview

Handle shell hooks without config section

What this PR does / why we need it

If executable hook doesn't have config section, shell-operator will panic. We need to handle this situation and throw an understandable error

Special notes for your reviewer

@yalosev yalosev added bug Something isn't working go Pull requests that update Go code labels Oct 20, 2023
@yalosev yalosev requested a review from nabokihms October 20, 2023 12:00
@nabokihms nabokihms merged commit e6b2d55 into main Oct 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees
No one assigned
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yalosev @nabokihms