Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate metric storages #549

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Separate metric storages #549

merged 4 commits into from
Oct 31, 2023

Conversation

yalosev
Copy link
Contributor

@yalosev yalosev commented Oct 30, 2023 •
edited
Loading

Overview

  • Separate HookMetricStorage and MetricStorage
    • MetricStorage collects base go metrics and shell-opertor built-in metrics and returns on /metrics
    • HookMetricStorage collects metrics from user hooks and returns on /metrics/hooks
  • Increase HTTP Server timeouts

What this PR does / why we need it

Separate base metrics from hook metrics

Special notes for your reviewer

@yalosev yalosev added enhancement New feature or request go Pull requests that update Go code labels Oct 30, 2023
@yalosev yalosev changed the title Fix metrics collectors Separate metric storages Oct 30, 2023
@yalosev yalosev requested a review from nabokihms October 30, 2023 21:27
@nabokihms nabokihms merged commit be3366a into main Oct 31, 2023
18 checks passed
This was referenced Nov 22, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yalosev @nabokihms