[2.x] Codebase cleanup #4161
Open
[2.x] Codebase cleanup #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method can either return `int` or `null`. There is no need to coalesce `null` into `null`.
No modifier = `public`, therefore I've added `public`.
Apparently PHPStan can't tell that the scope returns a model instance.
This method can't return `null` - we are throwing an exception if that's the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to cleanup the codebase as well as utilize the latest technologies provided by PHP up to 8.2.
It's a pretty big one, but I've cut everything up into lots of commits, so if you don't like something, it's easily revertable.
There are no breaking changes here. Code style will have to be updated by StyleCI(?) - though, I wish there was php-cs-fixer or something like that included in the project, so I could properly adhere to the coding styles without thinking about it too much.