Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle new UUID #112

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Bundle new UUID #112

merged 8 commits into from
Sep 29, 2023

Conversation

TymKh
Copy link
Collaborator

@TymKh TymKh commented Sep 5, 2023

📝 Summary

Groundwork for using unique deterministic ID for bundles

Example of new inserted bundle from goerli (json extracted from db, stripped from irrelevant data):

[
  {
    "id": 47188143,
    "bundle_hash": "0xc7c4bfddd2210bf883e5969c0d7824333f3b52433a452362c2b7b0dd31921f42",
    "param_block_number": 9732877,
    "error_message": null,
    "gas_fees": 0,
    "has_error": false,
    "version": 2,
    "param_reverting_tx_hashes": "",
    "is_high_prio": true,
    "owner_queue": "6cqwv",
    "replacement_uuid": null,
    "bundle_uuid": "000009a2-b7b1-5de3-8e35-7e6ba2209873"
  }
] 

📚 References


return buf
}

func (b *MevBundle) ComputeUUID() uuid.UUID {
Copy link
Contributor

@Wazzymandias Wazzymandias Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking)

We should probably eventually use a sync.Once pattern to initialize the UUID once since we don't mutate bundles after initialization

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought in a little bit different direction, I believe we'll eventually move to propagating this uuid as a field of bundle structure, but it'd be better be done once we have some module with shared models. But I anyway understand your concern, I hope we'll address it in future

@Wazzymandias
Copy link
Contributor

looks great!

Could you update your PR description with output successfully showing bundles inserted into database with the new schema and UUID?

Otherwise lgtm, good stuff

@TymKh
Copy link
Collaborator Author

TymKh commented Sep 24, 2023

looks great!

Could you update your PR description with output successfully showing bundles inserted into database with the new schema and UUID?

Otherwise lgtm, good stuff

Done

@TymKh TymKh merged commit 7f43d0b into main Sep 29, 2023
3 checks passed
@TymKh TymKh deleted the bundle-new-uuid branch September 29, 2023 22:43
estensen pushed a commit to estensen/builder that referenced this pull request Nov 16, 2023
* fix issue with geth not shutting down (flashbots#97)
* Add eth_callBundle rpc method (flashbots#14)
* flashbots: add eth_estimateGasBundle (flashbots#102)
* feat(ethash): flashbots_getWork RPC with profit (flashbots#106)
* Calculate megabundle as soon as it's received (flashbots#112)
* Add v0.5 specification link (flashbots#118)
vazha pushed a commit to vazha/builder that referenced this pull request Feb 2, 2024
* fix issue with geth not shutting down (flashbots#97)
* Add eth_callBundle rpc method (flashbots#14)
* flashbots: add eth_estimateGasBundle (flashbots#102)
* feat(ethash): flashbots_getWork RPC with profit (flashbots#106)
* Calculate megabundle as soon as it's received (flashbots#112)
* Add v0.5 specification link (flashbots#118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants