Potential private tx leak on builder restart #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhenryhunter
requested review from
dvush,
TymKh,
Ruteri and
avalonche
as code owners
avalonche
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This keeps all private TXs from being added to the tx journal, which will store and reimport the transactions on restart. If a private TX is sent to the builder at time of a restart it could be leaked due to the tx being reimported and not tracked as private correctly.
📚 References
Where it is added to journal:
https://github.com/benhenryhunter/builder/blob/main/core/txpool/legacypool/legacypool.go/#L825-L834
Where journal TXs are all imported and not marked as private:
https://github.com/benhenryhunter/builder/blob/main/core/txpool/legacypool/legacypool.go/#L957-L960
CONTRIBUTING.md