Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial] [Breaking Change] Migrate some miner CLI flags to builder #88

Merged
merged 6 commits into from
Jul 28, 2023
Merged

[trivial] [Breaking Change] Migrate some miner CLI flags to builder #88

merged 6 commits into from
Jul 28, 2023

Conversation

Wazzymandias
Copy link
Contributor

@Wazzymandias Wazzymandias commented Jul 24, 2023 •
edited
Loading

📝 Summary

  • Copy --miner.algotype to --builder.algotype
  • Move --miner.price_cutoff_percent to --builder.price_cutoff_percent
  • Both flags still used in miner configuration since migrating configuration is nontrivial
  • This change helps us incrementally move away from miner package which is deprecated. However, it requires discussion with team to see whether we merge this, since it fragments configuration instantiation between builder and miner structs.
    • This PR may get closed if team decides not worth it
  • Note: This is a breaking change

📚 References

avalonche
avalonche reviewed Jul 25, 2023
View reviewed changes
README.md Show resolved Hide resolved
avalonche
avalonche reviewed Jul 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
avalonche
avalonche reviewed Jul 25, 2023
View reviewed changes
cmd/utils/flags.go Outdated Show resolved Hide resolved
avalonche
avalonche reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mark as breaking change

Wazzymandias and others added 2 commits July 24, 2023 22:15
@Wazzymandias Wazzymandias changed the title [trivial] Migrate some miner CLI flags to builder [trivial] [Breaking Change] Migrate some miner CLI flags to builder Jul 25, 2023
@Wazzymandias
Add back original flags with deprecation notice for backwards compati…
c862c29 
…bility, rename builder.validation_blacklist to builder.blacklist
@Wazzymandias Wazzymandias changed the title [trivial] [Breaking Change] Migrate some miner CLI flags to builder [trivial] Migrate some miner CLI flags to builder Jul 27, 2023
@Wazzymandias Wazzymandias changed the title [trivial] Migrate some miner CLI flags to builder [trivial] [Breaking Change] Migrate some miner CLI flags to builder Jul 27, 2023
avalonche
avalonche reviewed Jul 28, 2023
View reviewed changes
README.md Show resolved Hide resolved
avalonche
avalonche reviewed Jul 28, 2023
View reviewed changes
README.md Show resolved Hide resolved
avalonche
avalonche reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are other parts of the README that references the validation flags, please check and update accordingly

@Wazzymandias Wazzymandias merged commit 893d4c8 into main Jul 28, 2023
3 checks passed
@Wazzymandias Wazzymandias deleted the refactor-miner-flag branch July 28, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukoneck sukoneck sukoneck approved these changes

@dvush dvush dvush approved these changes

@avalonche avalonche avalonche approved these changes

@Ruteri Ruteri Awaiting requested review from Ruteri Ruteri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wazzymandias @sukoneck @dvush @avalonche