Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code health] refactor floor bid checks to independent function #513

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

michaelneuder
Copy link
Collaborator

πŸ“ Summary

Pull the floor checks into an independent function.

Part of series: #479, #491, #494, #498.

β›± Motivation and Context

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #513 (1bf97ea) into main (13ede49) will increase coverage by 0.43%.
The diff coverage is 65.38%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   31.70%   32.14%   +0.43%     
==========================================
  Files          24       24              
  Lines        4860     4878      +18     
==========================================
+ Hits         1541     1568      +27     
+ Misses       3127     3118       -9     
  Partials      192      192              
Flag Coverage Ξ”
unittests 32.14% <65.38%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Ξ”
datastore/redis.go 59.71% <0.00%> (-0.49%) ⬇️
services/api/service.go 39.13% <70.83%> (+1.25%) ⬆️

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@michaelneuder michaelneuder merged commit dabae5e into main Aug 30, 2023
4 checks passed
@michaelneuder michaelneuder deleted the mikeneuder-2023-08-29-3 branch August 30, 2023 14:04
@michaelneuder michaelneuder mentioned this pull request Sep 15, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants