Use SSZ encoding for block validation #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
commented
Apr 8, 2024
| } | ||
|
|
||
| httpReq.Header.Add("Content-Type", "application/octet-stream") | ||
| httpReq.Header.Add("Eth-Consensus-Version", strings.ToLower(req.Version.String())) |
There was a problem hiding this comment.
allow future forks to reuse the same endpoint instead of a new endpoint incremented by version number, like in the JSON RPC endpoint.
metachris
reviewed
Apr 10, 2024
| apiDefaultLogTag = os.Getenv("LOG_TAG") | ||
| apiDefaultListenAddr = common.GetEnv("LISTEN_ADDR", "localhost:9062") | ||
| apiDefaultBlockSim = common.GetEnv("BLOCKSIM_URI", "http://localhost:8545") | ||
| apiDefaultBlockSimHTTP = common.GetEnv("BLOCKSIM_HTTP_URI", "http://localhost:28546") |
There was a problem hiding this comment.
please add comments to the two BLOCKSIM_URI to clarify what they are used for
metachris
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Uses SSZ to send block validation payloads to the validation node. Instead of JSON RPC, a new HTTP endpoint is needed to post SSZ payloads, implemented like in flashbots/builder#152.
⛱ Motivation and Context
Improve block submission latency at the relay.
📚 References
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md