Update BidTrace #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
Dec 5, 2022
jtraglia
approved these changes
Dec 7, 2022
6 tasks
metachris
added a commit
that referenced
this pull request
May 19, 2023
This reverts commit adae2d4.
Merged
metachris
added a commit
that referenced
this pull request
May 19, 2023
|
Sorry I was too quick with merging this -- the endpoints do not currently return |
|
i think the endpoints should return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the BidTrace(V2->V3) to include a timestamp by default and have an extra_data field. BidTraceV3 inherits from BidTraceV2WithTimestamp and adds an extra_data field as proposed by @metachris .
relay/v1/data/bidtraces/proposer_payload_delivered and relay/v1/data/bidtraces/builder_blocks_received endpoints both return a BidTraceV3 now.
The need for this proposal is discussed here:
flashbots/mev-boost-relay#257