Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Detect dark theme for GTK based DEs like elementary OS #213

Closed
wants to merge 2 commits into from

Conversation

Alecaddd
Copy link

@Alecaddd Alecaddd commented Dec 1, 2021

I'd like to propose the addition of the --system-talk-name=org.freedesktop.Accounts argument to enable the detection of the Dark/Light variation on GTK based distros that follow the FreeDesktop specifications.

I'd like to propose the addition of the `--system-talk-name=org.freedesktop.Accounts` argument to enable the detection of the Dark/Light variation on GTK based distros that follow the FreeDesktop specifications.
@flathubbot
Copy link

Started test build 69254

@flathubbot
Copy link

Build 69254 failed

Fixed missing comma in json file.
@flathubbot
Copy link

Started test build 69262

@Erick555
Copy link
Collaborator

Erick555 commented Dec 1, 2021

Thx, can you confirm without this change theme detection doesn't work and with it it does?

@flathubbot
Copy link

Build 69262 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/67099/org.mozilla.Thunderbird.flatpakref

@Erick555
Copy link
Collaborator

Erick555 commented Dec 1, 2021

From the info I gathered gnome doesn't need this permission alongside latest elementary or even kde.

@Alecaddd
Copy link
Author

Alecaddd commented Dec 1, 2021

Confirming that with the current flatpak stable release, theme detection doesn't work in elementary OS.
Screenshot from 2021-12-01 13-46-37

Testing the build now.

@Alecaddd
Copy link
Author

Alecaddd commented Dec 1, 2021

Nope, nevermind.
That argument doesn't do anything and the application doesn't follow the OS theme variation.
This seems to be an issue with elementary OS since in Ubuntu it works even without the argument.
Apologies for the noise.

@Alecaddd Alecaddd closed this Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants