Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis and integer types #167

Open
billbrod opened this issue Jun 10, 2024 · 0 comments
Open

Basis and integer types #167

billbrod opened this issue Jun 10, 2024 · 0 comments

Comments

@billbrod
Copy link
Member

When trying to cross-validate on the basis's window_size (on branch development, making use of TransformerBasis), I called:

[nmo.basis.RaisedCosineBasisLog(8, mode='conv', window_size=ws) 
 for ws in np.arange(100, 301, 50)]

This fails, because we check isinstance(window_size, int) and the output of np.arange is not a default numpy integer. Should figure out the proper check here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant