Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sin_minpoly and tan_minpoly #145

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Implement sin_minpoly and tan_minpoly #145

wants to merge 6 commits into from

Conversation

videlec
Copy link
Collaborator

@videlec videlec commented Feb 3, 2022

Fixes #143

@videlec videlec marked this pull request as draft February 3, 2022 10:46
@videlec
Copy link
Collaborator Author

videlec commented Feb 3, 2022

In theory one can compute tan_minpoly from cos_minpoly and sin_minpoly using the composed_op method of polynomials. But this is very inefficient because we create a very high degree polynomial that we then need to factorize to take only one of its factors. This is not the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not rely on subfield to create the base ring in EquiangularPolygons
2 participants
@videlec @saraedum