-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MutableOrientedHyperbolicSurface #243
base: master
Are you sure you want to change the base?
Conversation
Documentation preview for this PR is ready! 🎉 |
we are not doing any layouting here so the result is probably mostly useless.
we need to make sure that point coordinates are hashable (for the representatives set.) Also, it's probably helpful that all points have the same structure (and not some are tuples say.) If there's a performance impact, we might revisit the implementation later but points are not used much currently anyway.
This reverts commit 433999d. We must not normalize points such as the ones that come from hyperbolic points since there coordinates are not always available.
You can actually call |
and revert equality of ordered sets without further assumptions on the data.
A useful method at the level of surfaces glued from polygon is |
Checklist
doc/news/
.doc/geometry
ordoc/graphical
.TODO
edges()
of polygons with marked vertices should return the individual segments surrounding a marked vertex Fix edges() of hyperbolic convex polygons with marked vertices #244Add polygons mod n formed by inserting orbifold points in a followup PR.Demo